⚠️ No Changeset found

Latest commit: 92ce51c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jussirantala Could you try and recreate the issue in a test case or raise an issue with a minimal reproduction? I can't manage to get chunkInfo.fileName to contain a relative path as rollup prevents emitting files to relative paths. Is there another way to get relative filenames?

@jussirantala Could you try and recreate the issue in a test case or raise an issue with a minimal reproduction? I can't manage to get chunkInfo.fileName to contain a relative path as rollup prevents emitting files to relative paths. Is there another way to get relative filenames?

@askoufis I'll try to find time for that but what do you mean with rollup preventing emitting files to relative paths? You just need to have something being imported from a upper directory. For example you could import some classes in your styling file from ../internal/baseStyles but this bug changes the path to ./internal/baseStyles causing a broken build.

@askoufis

So you were using Windows when you tested, right?

@jussirantala I'm still not able to reproduce what you're talking about. This was my attempt to understand you situation. I made a nested entrypoint in a package that imports a file from a parent directory. The relative path looks correct to me.

This is why it would be very helpful if you could create a minimal reproduction of the issue in a repo so I can test it out. Alternative, if you fork the repo and create a failing test case then that would also be useful so I can validate your solution.

@jussirantala I'm still not able to reproduce what you're talking about. This was my attempt to understand you situation. I made a nested entrypoint in a package that imports a file from a parent directory. The relative path looks correct to me.

This is why it would be very helpful if you could create a minimal reproduction of the issue in a repo so I can test it out. Alternative, if you fork the repo and create a failing test case then that would also be useful so I can validate your solution.

@askoufis
It doesn't look correct to me: https://github.com/vanilla-extract-css/vanilla-extract/compare/rollup-windows-path-test?expand=1#diff-71eed780184ba3d1ce66f1cce1ba6872fa8d58d1237f7ed6e462bdccc24e3327R876

It's pointing to current directory instead of the upper directory.

It's pointing to current directory instead of the upper directory.

@jussirantala
It's pointing to the current directory because that's where the file is emitted to. If I change the rollup input so it emits that file into a nested directory, then the imports reference the parent directory. See here. The ./.. in the import paths is a bit strange but it's a simple way to enforce a relative path in all cases, and has worked fine for years in the plugin.

Once again, I'd greatly appreciate if you could make a minimal reproduction of your specific issue, instead of me trying to blindly reproduce it.

Thanks for testing it. I will try to find out time for the minimal repro.